Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: move creation of /go dir lower #3958

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Dockerfile: move creation of /go dir lower #3958

merged 1 commit into from
Nov 21, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 20, 2024

That way it's more obvious that it's empty and it's purely for OpenShift CI compatibility.

@jlebon
Dockerfile: move creation of /go dir lower
d9dac45 
That way it's more obvious that it's empty and it's purely for OpenShift
CI compatibility.
@jlebon jlebon mentioned this pull request Nov 20, 2024
Merged
@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2024

/retest

dustymabe
dustymabe approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

/retest ci/prow/images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

@dustymabe: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test rhcos

Use /test all to run all jobs.

In response to this:

/retest ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustymabe
Copy link
Member

/test ci/prow/images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

@dustymabe: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test rhcos

Use /test all to run all jobs.

In response to this:

/test ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustymabe dustymabe enabled auto-merge (rebase) November 20, 2024 21:54
@dustymabe
Copy link
Member

/test images

@dustymabe
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 21, 2024

@jlebon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images d9dac45 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustymabe dustymabe merged commit 7ef008c into coreos:main Nov 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlebon @dustymabe